Re: [UPDATED v3][PATCH 5/7] regulator: sysfs ABI

From: David Brownell
Date: Fri Mar 07 2008 - 20:40:41 EST


On Friday 07 March 2008, Mark Brown wrote:
> On Fri, Mar 07, 2008 at 08:12:12AM -0800, Greg KH wrote:
> > On Thu, Mar 06, 2008 at 06:12:05PM +0000, Liam Girdwood wrote:
>
> > > + Some regulator directories will contain a link called parent.
> > > + This points to the parent or supply regulator if one exists.
>
> > I don't think this is needed, why not just parent the device properly in
> > the device tree itself?
>
> The device tree would tend to show parent for the the control interfaces
> for the regulators (typically I2C or SPI) but there is likely to be
> little or no relationship between that and the power distribution in the
> system.

I find "parent" a bit awkward, and Greg won't be the only one to
be asking that question. Maybe it'd be better named "supply"?

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/