Re: [PATCH] [6/13] Core maskable allocator

[Randy Dunlap]

On Fri, 7 Mar 2008 18:43:16 +0100 Andi Kleen wrote:

> On Fri, Mar 07, 2008 at 09:33:02AM -0800, Randy Dunlap wrote:
> > Andi Kleen wrote:
> > >>>+	maskzone=size[MG] Set size of maskable DMA zone to size.
> > >>>+		 force	Always allocate from the mask zone (for testing)
> > >>                 ^^^^^^^^^^^^^ ??
> > >
> > >What is your question?
> > 
> > That line seems odd.  Is it correct?
> > Why 2 spaces between force and Always?  Why is Always capitalized?
> > Could one of those words be dropped?  They seem a bit redundant.
> 
> The option is either maskzone=size[MG] or maskzone=force
> Each followed with a sentence describing them.

Oh.  I see.

> I tried to make this clear by lining them up, but apparently failed.
> You have a preferred way to formatting such multiple choice options?

I don't know that we have a certain/fixed way for that.

How about:

	maskzone=
		Format: {size[MG] | force}
		size -- Set size of maskable DMA zone to size
		force -- Always allocate from the mask zone (for testing)


---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/