Re: [PATCH] [SDIO] add vendor and product pair for SQN1130

From: Pierre Ossman
Date: Fri Mar 07 2008 - 06:43:02 EST


On Fri, 7 Mar 2008 02:45:26 -0800
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Fri, 7 Mar 2008 10:08:30 +0200 Andy Shevchenko <andy@xxxxxxxxxxxx> wrote:
>
> > Add the vendor and product ids for Sequans SQN1130 WiMAX chipset.
> > ---
> > include/linux/mmc/sdio_ids.h | 3 +++
> > 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
> > index ea1bf5b..d1b9883 100644
> > --- a/include/linux/mmc/sdio_ids.h
> > +++ b/include/linux/mmc/sdio_ids.h
> > @@ -26,4 +26,7 @@
> > #define SDIO_VENDOR_ID_MARVELL 0x02df
> > #define SDIO_DEVICE_ID_MARVELL_LIBERTAS 0x9103
> >
> > +#define SDIO_VENDOR_ID_SEQUANS 0x039d
> > +#define SDIO_DEVICE_ID_SEQUANS_SQN1130 0x046a
> > +
>
> There's no point in adding these unless there's actually some code there
> which _uses_ them?

Agreed. This is just noise.

--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/