Re: [PATCH] x86_64: show apicid for cpu in proc

[Yinghai Lu]

On 06 Mar 2008 12:41:46 +0100, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> "Yinghai Lu" <yhlu.kernel@xxxxxxxxx> writes:
>
>  >                          cpus_weight(per_cpu(cpu_core_map, cpu)));
>  >               seq_printf(m, "core id\t\t: %d\n", c->cpu_core_id);
>  >               seq_printf(m, "cpu cores\t: %d\n", c->booted_cores);
>
> > +             seq_printf(m, "apicid\t: %02x\n", c->apicid);
>
>  Seems a little redundant with the boot log, but ok.
>
>  But it's unclear to the user which apic ID is meant by that. There are
>  two different ones. The one in the LAPIC mapping and the one reported by
>  CPUID. They are not necessarily the same. I think you should clarify that
>  by renaming the field or perhaps report both.

report the apicid and initial apicid at the same time?

but in current code, we didn't use the initial apicid...., actually
initial apic id is more better to get the responding to node/core.

will look at it.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/