Re: [patch 2/2] x86, fpu: lazy allocation of FPU area - v3

[Ingo Molnar]

* Pavel Machek <pavel@xxxxxx> wrote:

> > > kmem_cache_alloc() can fail (return NULL) and not handling it is a 
> > > bug.
> > 
> > oops. you are correct. Will send a sigsegv in the failure case then. 
> > Thanks.
> 
> You are introducing possibility of hard to debug error, where previous 
> code just worked... Does not look like good idea to me.

hm, how does it differ from any other allocation failure? We could fail 
to allocate a pagetable page. We could fail to allocate the task_struct 
to begin with.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/