Re: [PATCH] Modify loop device to be able to manage partitions ofthe disk image

[Laurent Vivier]

Le jeudi 06 mars 2008 Ã 11:34 +0000, PÃdraig Brady a Ãcrit :
> Laurent Vivier wrote:
> > This patch allows to use loop device with partitionned disk image.
> > 
> > Original behavior of loop is not modified.
> > 
> > A new parameter is introduced to define how many partition we want to be
> > able to manage per loop device. This parameter is "max_part".
> 
> I like it!

Thanks,

> Shouldn't we set max_part to non zero by default though?

Well, the problem is that you modify the default minor number of loop
device if max_part != 0, so I'm afraid of compatibility problems:
with max_part=0, loop0 is minor 0, loop1 is minor 1,
with max_part=63, loop0 is minor 0, loop1 is minor 64, whereas loop0p1
is minor 1.

> Hopefully I can throw away my loopback partition mounting script soon :)
> http://www.pixelbeat.org/scripts/lomount.sh
> 
> cheers,
> PÃdraig.
> 

Regards,
Laurent
-- 
----------------- Laurent.Vivier@xxxxxxxx  ------------------
"Programmers who subconsciously view themselves as artists
 will enjoy what they do and will do it better." D. Knuth

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/