Re: [PATCH] checkpatch: Make some text more consinstent and informative

[Andy Whitcroft]

On Wed, Mar 05, 2008 at 09:49:12PM +0100, Paolo Ciarrocchi wrote:
> Hi Andy,
> 
> Now messages about missing spaces or not needed spaces are in the format:
> 	space is required
> 	space is not required
> 
> Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@xxxxxxxxx>

The current version (which your patch has crossed with) has these changed
to "required" and "prohibited" respectivly, to remove the ambiguity introduced by
tehe "no spaces X" form.

I did consider and reject the "is not required" form.  In english this
does not correct carry the "must not be present" meaning, it more means
"may or may not be present at your option".  Which is not what we are
trying to say either.

Hopefully the new wording is clearer to native and non-native english
speakers alike.

Thanks for doing the patch even so.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/