[PATCH -mm] send_group_sigqueue: don't take tasklist_lock

From: Oleg Nesterov
Date: Wed Mar 05 2008 - 19:05:39 EST


(depends on signals-re-assign-cld_continued-notification-from-the-sender-to-reciever.patch)

handle_stop_signal() was changed, now send_group_sigqueue() doesn't need
tasklist_lock.

Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

--- 25/kernel/signal.c~5_SGS_NO_TASKLIST 2008-03-06 01:34:57.000000000 +0300
+++ 25/kernel/signal.c 2008-03-06 02:54:27.000000000 +0300
@@ -1336,7 +1336,6 @@ send_group_sigqueue(int sig, struct sigq

BUG_ON(!(q->flags & SIGQUEUE_PREALLOC));

- read_lock(&tasklist_lock);
/* Since it_lock is held, p->sighand cannot be NULL. */
spin_lock_irqsave(&p->sighand->siglock, flags);

@@ -1345,7 +1344,7 @@ send_group_sigqueue(int sig, struct sigq
__group_complete_signal(sig, p);

spin_unlock_irqrestore(&p->sighand->siglock, flags);
- read_unlock(&tasklist_lock);
+
return ret;
}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/