Re: New 2.6.24.2 SG_IO SCSI problems

[Mike Christie]

James Bottomley wrote:
> On Wed, 2008-03-05 at 06:58 -0500, Mark Hounschell wrote:
> > Mike Christie wrote:
> > > Mark Hounschell wrote:
> > > > Mark Hounschell wrote:
> > > > > Mike Christie wrote:
> > > > > > Mike Christie wrote:
> > > > > > > Mark Hounschell wrote:
> > > > > > > > I seem to have run into some sort of regression in the SG_IO
> > > > > > > > interface of 2.6.24.2. I have an application that up until 2.6.24
> > > > > > > > worked fine. The 2.6.23.16 kernel works fine.
> > > > > > > >
> > > > > > > > During reads I get these kernel messages. Writes and other functions
> > > > > > > > _seem_ OK. Actually basic
> > > > > > > > reads  are working. Its with large BC reads using an io_vec list that
> > > > > > > > the problem shows up.
> > > > > > > Are you doing SG_IO to the sg device (/dev/sg*) or to the block device
> > > > > > > (/dev/sdX)?
> > > > > > If you are doing SG_IO to the sg device, then I know of one regression
> > > > > > (well not regression exactly, but I fixed a bug but the patch got
> > > > > > partially overwritten by another patch and that caused a new bug). Both
> > > > > > bugs are fixed in 2.6.25-rc2. Could you try that out if you are doing
> > > > > > SG_IO to the sg device.
> > > > > Yes, I'm using /dev/sg*. And yes again I'll checkout 2.6.25-rc2 ASIC.
> > > > >
> > > > > Thanks
> > > > > Mark
> > > > > -
> > > >  
> > > > 2.6.25-rc2 does fix the problem I'm having. I don't suppose there is a
> > > > patch
> > > > lying around for 2.6.24.2??
> > > I attached a backport of the patch from Tony (added as cc) that is in
> > > 2.6.25-rc2. Could you try it out against 2.6.24.2 just to make sure it
> > > was this patch, then we can send it to stable.
> > >
> > > Mark Hounschell wrote:
> > >
> > > Sorry it took so long. This does fix my problem. I hope it's not to
> > > late for 2.6.24.3
> > Backport
> > 76d78300a6eb8b7f08e47703b7e68a659ffc2053
> > to 2.6.24
>
> Erm, I think you mean:

You are right.

> commit 4d2de3a50ce19af2008a90636436a1bf5b3b697b
> Author: Tony Battersby <tonyb@xxxxxxxxxxxxxxx>
> Date:   Tue Feb 5 10:36:10 2008 -0500
>
>     [SCSI] fix BUG when sum(scatterlist) > bufflen
>
> I can send it ... I thought the error was introduced post 2.6.24, but it
> was actually in 2.6.24-rc1

Ok thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/