Re: WARNING: at drivers/usb/host/ehci-hcd.c:287

[David Brownell]

On Tuesday 04 March 2008, Alan Stern wrote:

> > > How about replacing the
> > > 
> > >         WARN_ON(!ehci->reclaim);
> > 
> > Or bettter yet, just removing it entirely.  ISTR doing that in some
> > patches I've not yet sent for merging, and expect that's what my
> > preferred fix will be ...
> 
> But removing the WARN_ON won't fix the problem.

It fully resolves the $SUBJECT problem.  :)


> The routine still 
> needs to exit immediately if ehci->reclaim isn't set,

It more or less does that already; it does some avoidable
work, but that's not incorrect.


> the root hub isn't running, or the timer has been restarted.

Those are different issues.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/