Re: preempt bug in set_pmd_pfn?

[Jeremy Fitzhardinge]

Ingo Molnar wrote:
> * Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
>
>   
> > I think set_pmd_pfn, which is only called by __set_fixmap, might have 
> > a preempt bug in it.
> >     
>
> yes, and we had similar preemption bugs in the past. I guess most places 
> are either infrequent or have some natural atomicity anyway. Wanna send 
> a patch?
>   

Sure.  Should it just disable preemption, or take a lock?  It calls 
set_pte_at without holding any pte locks; that seems to be relatively 
common.  Is it OK when you're operating on init_mm?

   J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/