Re: Patch: romfs_lookup always failed in linux-2.6.25-rc3-git3

[Adam J. Richter]

On Tue, Mar 04, 2008 at 02:32:43PM +0000, David Howells wrote:
> [...] Can you look over the attached patch as an alternative, please?

	Your new goto labels "error" and "success" (instead of "out"
and "out0") clarify the code enough to justify your removal of the
comment block, so that's all good.  My only question is why you've
changed res from int to long, given that you've corrected my misguided
"P.S.":

> Adam J. Richter <adam@xxxxxxxxxxxxx> wrote:
[...]
> > P.S. romfs_lookup casts a valid pointer to an int and then back again
> > with res = PTR_ERR(inode);...return ERR_PTR(res).  This may break on
> > arhictectures where sizeof(int) < sizeof(pointer).
> 
> This is not true.  [...]

	You're right.  My mistake.  Sorry for causing confusion.  But,
based on what you've just said, it doesn't sound like you need to
change res from int to long.  Is there some other issue I'm missing?

	Anyhow, if you want to do these changes together in a single
commit or separately, I'm fine with it either way.

Adam Richter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/