Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors

From: Andi Kleen
Date: Tue Mar 04 2008 - 13:32:59 EST


On Tue, Mar 04, 2008 at 07:04:46PM +0100, Pierre Ossman wrote:
> On Tue, 4 Mar 2008 18:43:15 +0100
> Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
>
> > > And how can I tell if this handler has run? Not that it really matters I guess, as I don't think running it from the cpuidle governor is very sane.
> >
> > After irq_enter->tick_nohz_update_jiffies()
> >
> > You might need a new callback into the idle governours for this though.
> >
>
> I don't think I quite see the point. If we can't force an update, then
> it doesn't really help us knowing if the jiffies value is stale or not.

What do you mean with force an update? The system always does an
jiffies update automatically after idle wakeup. It's just that if you add
code to the code path that uses jiffies you have to make sure it is after the
standard update, otherwise you'll see a stale value.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/