Re: [PATCH 06/17] Change the kernel configurated RapidIO systemsize to auto-probing.

[Stephen Rothwell]

On Wed,  5 Mar 2008 00:29:51 +0800 Zhang Wei <wei.zhang@xxxxxxxxxxxxx> wrote:
>
> +	if (!(rionet_active = (struct rio_dev **)__get_free_pages(GFP_KERNEL,
> +				mport->sys_size ? __ilog2(sizeof(void *)) + 4
> +				: 0))) {

Please separate the assignment from the test.

> +		if (!(rswitch->route_table = kzalloc(sizeof(u8)*
> +					RIO_MAX_ROUTE_ENTRIES(port->sys_size),
> +					GFP_KERNEL))) {

Again.

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature