Re: [PATCH] x86 pci: remove checking type for mmconfig probe v2

[Greg KH]

On Sat, Mar 01, 2008 at 12:36:50AM -0800, Yinghai Lu wrote:
> On Fri, Feb 29, 2008 at 10:02 PM, Greg KH <greg@xxxxxxxxx> wrote:
> > On Thu, Feb 28, 2008 at 11:56:50PM -0800, Yinghai Lu wrote:
> >  >
> >  > doesn't need to check if it is type1 or type2. we can use raw_pci_ops dirctly.
> >
> >  Why?  is this because the ops are already set up?  It would be nice to
> >  add the "why this change is necessary and/or possible now" for the
> >  changelog.
> yes.
> raw_pci_ops got assigned when check direct_type1 and direct_type2.
> and could used in hostbridge check to get MMCONF base.
> 
> make mmconfig probe clean
> with checking if raw_pci_ops is assigned instead of passing type or
> checking type.

Ah, ok, that makes sense, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/