Re: [PATCH 4/4] ACPI PCI slot detection driver

From: Greg KH
Date: Tue Mar 04 2008 - 00:53:58 EST


On Sat, Mar 01, 2008 at 07:43:07AM -0700, Matthew Wilcox wrote:
> On Fri, Feb 29, 2008 at 09:25:42PM -0800, Greg KH wrote:
> > What is the guarantee that the names of these slots are correct and do
> > not happen to be the same as the hotpluggable ones?
>
> That would be a bug -- and yes, bugs happen, and we have to deal with
> them.

My main concern is that BIOS vendors will not fix these bugs, as no
other OS cares/does this kind of thing today. The ammount of bad
information out there might be quite large, and I think this was
confirmed by some initial testing of IBM systems, right?

> > Why show this information on machines that can not do anything with
> > these slots at all? Will that not just confuse people?
>
> Only for people who think that /sys/bus/pci/slots/ is for hotpluggable
> slots only. There is plenty of useful information available for slots
> that aren't hotpluggable (eg bus address, speed, width, error status).

Can the userspace tools that are using the existing directories thinking
that only hotplug slots are there, handle "non-hotplug" slots showing up
in this location?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/