Re: [PATCH 08/14] scsi: replace remaining __FUNCTION__ occurrences

[Harvey Harrison]

On Mon, 2008-03-03 at 21:30 -0600, James Bottomley wrote:
> On Mon, 2008-03-03 at 19:09 -0800, Harvey Harrison wrote:
> > __FUNCTION__ is gcc-specific, use __func__
> 
> What on earth is the point of this?
> 
> We already have compiler specific files in 
> 
> include/linux/compiler-*
> 
> Which can be used to #define __FUNCTION__ to whatever the individual
> compiler wants.  That way we don't get thousands of lines of churn in
> the kernel for no value.
> 

1) Currently there is a mix of __FUNCTION__ and __func__ in the kernel,
and __func__ is ansi C (C99...)

2) It's shorter

3) When people look around to add new code, they will only see the one
way the kernel does it.

None of which are very convincing, but there you go.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/