Re: [patch 2/2] x86, fpu: lazy allocation of FPU area - v3

[Suresh Siddha]

On Mon, Mar 03, 2008 at 08:20:12PM -0500, Christoph Hellwig wrote:
> On Mon, Mar 03, 2008 at 03:02:46PM -0800, Suresh Siddha wrote:
> > +	/*
> > +	 * Memory allocation at the first usage of the FPU and other state.
> > +	 */
> > +	if (!tsk->thread.xstate)
> > +		tsk->thread.xstate = kmem_cache_alloc(task_xstate_cachep, GFP_KERNEL);
> 
> Please don't do over 80 char lines.

Ok.

>  Also don't we need some kind of error handling here?

Currently it uses SLAB_PANIC.

thanks,
suresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/