RE: [PATCH] cpuidle: avoid singing capacitors

From: Pallipadi, Venkatesh
Date: Mon Mar 03 2008 - 16:14:48 EST




>-----Original Message-----
>From: Pavel Machek [mailto:pavel@xxxxxx]
>Sent: Monday, March 03, 2008 1:09 PM
>To: Pierre Ossman
>Cc: Pallipadi, Venkatesh; Adam Belay;
>linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx; LKML; Andi Kleen; Lee Revell
>Subject: Re: [PATCH] cpuidle: avoid singing capacitors
>
>On Mon 2008-03-03 22:03:10, Pierre Ossman wrote:
>> On Mon, 3 Mar 2008 21:46:03 +0100
>> Pavel Machek <pavel@xxxxxx> wrote:
>>
>> > >
>> > > +static unsigned int min_deep_sleep = 2000;
>> > > +
>> >
>> > Well, why not, but I believe we should default to old
>behaviour... not
>> > all machines are cheaply-build.
>>
>> One would hope. ;)
>>
>> But the problem is that most people will not be able to find this
>> option (or even know such an option exists). I'd guess the
>distros will
>> just end up having this on by default anyway. And since I could not
>> measure any extra power drain, I believe it's hard to
>justify having it
>> off by default (more than by pure principle).
>
>So just leave it off by default, and let distros break their own
>kernels ;-).
>

I prefer leaving it off my default and enabling it on faulty hardware by
some blacklist.

Thanks,
Venki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/