Re: [PATCH 1/2] Add C99-style constructor macros for specific-sized integers

From: Segher Boessenkool
Date: Mon Mar 03 2008 - 15:23:59 EST


Do these new macros really buy anything over just writing LL in the
few places that 64-bit constants are used?

It gives you macros that matches the s64/u64 et al definitions are, thus avoiding another class of spurious warnings.

GCC doesn't warn for implicit narrowing that doesn't change value.

The printk() example is a read herring IMHO, since variable arguments
functions are "very speshul" anyway, and require explicit casts in
many cases.


Segher

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/