Re: [PATCH] Removing unneeded statement from tcp_ipv4.c

From: David Miller
Date: Mon Mar 03 2008 - 13:51:33 EST


From: Arnd Hannemann <hannemann@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 03 Mar 2008 14:23:38 +0100

> - if (tmp_opt.saw_tstamp && !tmp_opt.rcv_tsval) {
> + if (tmp_opt.saw_tstamp && !tmp_opt.rcv_tsval)
> /* Some OSes (unknown ones, but I see them on web server, which
> * contains information interesting only for windows'
> * users) do not send their stamp in SYN. It is easy case.
> * We simply do not advertise TS support.
> */
> tmp_opt.saw_tstamp = 0;
> - tmp_opt.tstamp_ok = 0;
> - }
> +

Please don't format it like this.

When there is a multi-line comment, you should still enclose
the basic block in braces. It's unreadable otherwise.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/