Re: [patch 1/7] Immediate Values - Architecture Independent Code

From: Jason Baron
Date: Thu Feb 28 2008 - 11:51:17 EST


On Wed, Feb 27, 2008 at 02:05:19PM -0500, Mathieu Desnoyers wrote:
> > +struct stop_machine_data {
> > + int (*fn)(void *);
> > + void *data;
> > + struct completion done;
> > + int run_all;
> > +} smdata;
> > +
>
> Why do we now have to declare this static ? Can we pass it as a pointer
> to stopmachine instead ?
>

Since the other cpus need to access 'fn', i made smdata a global.
stop_machine_run() is system-wide, so we only need one of these...

thanks,

-Jason

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/