Re: [rfc][patch] x86-64 new smp_call_function design

From: Ingo Molnar
Date: Wed Feb 27 2008 - 10:02:35 EST



* Nick Piggin <npiggin@xxxxxxx> wrote:

> > the two structures are quite similar in size and role - why not have
> > a type field and handle them largely together? I think we should try
> > to preserve a single queue and a single vector - that would remove a
> > number of ugly special-cases from the patch.
>
> A single queue will kill one of the big fundamental scalability
> improvements of the call_single. That's the problem.

hm, indeed. Then how about the other way around: couldnt the normal
all-cpus SMP function call be implemented transparently via using
smp_call_single() calls? The vector duplication is really ugly and feels
wrong.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/