Re: [RFC] mmiotrace full patch, preview 1

[Ingo Molnar]

* Andy Whitcroft <apw@xxxxxxxxxxxx> wrote:

> Ok, so that would be the following, work for everyone?
> 
> WARNING: mutexes are preferred for single holder semaphores
> #1: FILE: Z95.c:1:
> +       DECLARE_MUTEX(&foo);
> 
> WARNING: mutexes are preferred for single holder semaphores
> #3: FILE: Z95.c:3:
> +       init_MUTEX(&foo);

yeah.

  Acked-by: Ingo Molnar <mingo@xxxxxxx>

also i guess init_MUTEX_LOCKED() should emit a "this should be a 
completion" warning.

i guess non-DEFINE_SPINLOCK old-style spinlock definition:

  spinlock_t lock = SPIN_LOCK_UNLOCKED;

should emit a 'use DEFINE_SPINLOCK' warning as well?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/