Re: [PATCH 2/2] ResCounter: Use read_uint in memory controller

From: Andrew Morton
Date: Sat Feb 23 2008 - 14:00:39 EST


On Sat, 23 Feb 2008 06:33:34 -0800 "Paul Menage" <menage@xxxxxxxxxx> wrote:

> On Thu, Feb 21, 2008 at 8:29 PM, Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > Looks good, except for the name uint(), can we make it u64(). Integers are 32
> > bit on both ILP32 and LP64, but we really read/write 64 bit values.
>
> Yes, that's true. But read_uint() is more consistent with all the
> other instances in cgroups and subsystems. So if we were to call it
> res_counter_read_u64() I'd also want to rename all the other
> *read_uint functions/fields to *read_u64 too. Can I do that in a
> separate patch?
>

Sounds sensible to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/