Re: [PATCH 20/20] x86: Coding Style fixes toarch/x86/xen/multicalls.c

[Ingo Molnar]

* Joe Perches <joe@xxxxxxxxxxx> wrote:

> >  			printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
> >  			       ret, smp_processor_id());
> > -			for(i = 0; i < b->mcidx; i++) {
> > +			for (i = 0; i < b->mcidx; i++) {
> >  				printk("  call %2d/%d: op=%lu arg=[%lx] result=%ld\n",
> 
> The printk needs a KERN_ERR prefix

yes - but we prefer to isolate the "does not change the .o in any way" 
cleanups from cleanups that materially change kernel behavior. (such as 
printing something else)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/