Re: [PATCH 2/2] ResCounter: Use read_uint in memory controller

From: Andrew Morton
Date: Sat Feb 23 2008 - 03:24:18 EST


On Fri, 22 Feb 2008 09:59:41 +0530 Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote:

> menage@xxxxxxxxxx wrote:
> > Update the memory controller to use read_uint for its
> > limit/usage/failcnt control files, calling the new
> > res_counter_read_uint() function.
> >
> > Signed-off-by: Paul Menage <menage@xxxxxxxxxx>
> >
>
> Hi, Paul,
>
> Looks good, except for the name uint(), can we make it u64(). Integers are 32
> bit on both ILP32 and LP64, but we really read/write 64 bit values.
>

yup, I agree. Even though I don't know what ILP32 and LP64 are ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/