Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.25-rc2System no longer powers off aftersuspend-to-disk. Screen becomes green.)

From: Linus Torvalds
Date: Fri Feb 22 2008 - 21:09:21 EST




On Sat, 23 Feb 2008, Rafael J. Wysocki wrote:
>
> In the revised patch below I redefined the PM_EVENT_* things as flags so
> that I can "or" them and defined PM_EVENT_SLEEP in analogy with
> CONFIG_PM_SLEEP.

Ok, looks fine by me.

> > Didn't you miss the apci_pci_choose_state() thing that also needs this
> > extension?
>
> No, I didn't. That one operates on the ACPI D* states.

Ok. I consider that just about the worst interface ever, but whatever...

> OK, please have a look at the modified patch below.

All right, I'm fine with it. Now we just need to confirm that it works for
people..

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/