[PATCH] char: static functions and integer as NULL pointer fixesin epca.c

From: Harvey Harrison
Date: Fri Feb 22 2008 - 13:20:12 EST


drivers/char/epca.c:926:28: warning: Using plain integer as NULL pointer
drivers/char/epca.c:1841:2: warning: Using plain integer as NULL pointer

Forward declarations were already marked static, mark the definitions too.
drivers/char/epca.c:2493:6: warning: symbol 'digi_send_break' was not declared. Should it be static?
drivers/char/epca.c:2881:12: warning: symbol 'init_PCI' was not declared. Should it be static?

Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>
---
drivers/char/epca.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/char/epca.c b/drivers/char/epca.c
index ffd747c..b034b37 100644
--- a/drivers/char/epca.c
+++ b/drivers/char/epca.c
@@ -923,7 +923,7 @@ static int pc_open(struct tty_struct *tty, struct file * filp)
return(-ENODEV);
}

- if ((bc = ch->brdchan) == 0) {
+ if ((bc = ch->brdchan) == NULL) {
tty->driver_data = NULL;
return -ENODEV;
}
@@ -1838,7 +1838,7 @@ static void epcaparam(struct tty_struct *tty, struct channel *ch)
unsigned mval, hflow, cflag, iflag;

bc = ch->brdchan;
- epcaassert(bc !=0, "bc out of range");
+ epcaassert(bc != NULL, "bc out of range");

assertgwinon(ch);
ts = tty->termios;
@@ -2490,7 +2490,7 @@ static void pc_unthrottle(struct tty_struct *tty)
}
}

-void digi_send_break(struct channel *ch, int msec)
+static void digi_send_break(struct channel *ch, int msec)
{
unsigned long flags;

@@ -2878,7 +2878,7 @@ static struct pci_device_id epca_pci_tbl[] = {

MODULE_DEVICE_TABLE(pci, epca_pci_tbl);

-int __init init_PCI (void)
+static int __init init_PCI (void)
{
memset (&epca_driver, 0, sizeof (epca_driver));
epca_driver.name = "epca";
--
1.5.4.2.200.g99e75



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/