RE: [PATCH 1/1] scsi: megaraid_sas - Fix random failure of DCDBcmds with sense info

From: James Bottomley
Date: Fri Feb 22 2008 - 11:35:50 EST



On Fri, 2008-02-22 at 09:17 -0700, Yang, Bo wrote:
> James,
>
> What is the status for this patch? We need to submit more patches based
> on the acceptance of this patch.

OK, read the thread; Matthew is right. What you propose would pretty
much destroy compat ioctl handling within the driver. You need a compat
handler for MEGASAS_IOC_FW.

With your current patch you'd get a failure both from a 64 bit binary
running on x86-64 and if someone ran the x86 binary on ia64.

The driver already uses the compat infrastructure, it shouldn't be too
hard to add this in the correct manner.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/