[patch] Remove unneeded null tty check in drivers/usb/serial/io_ti.c

[Ray Lee]

The Coverity checker (and Adrian Bunk) spotted an inconsistent
NULL check of port->tty (it's blindly dereferenced later without
the check).

Alan Cox confirmed the check can go.

Signed-off-by: Ray Lee <ray-lk@xxxxxxxxxxxxx>

cc: linux-usb@xxxxxxxxxxxxxxx
cc: Greg KH <gregkh@xxxxxxx>
cc: Adrian Bunk <bunk@xxxxxxxxxx>
cc: linux-kernel@xxxxxxxxxxxxxxx
cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>

Index: linux-2.6/drivers/usb/serial/io_ti.c
===================================================================
--- linux-2.6.orig/drivers/usb/serial/io_ti.c	2008-02-22 07:26:47.000000000 -0800
+++ linux-2.6/drivers/usb/serial/io_ti.c	2008-02-22 07:28:12.000000000 -0800
@@ -1944,8 +1944,7 @@ static int edge_open (struct usb_serial_
 	if (edge_port == NULL)
 		return -ENODEV;

-	if (port->tty)
-		port->tty->low_latency = low_latency;
+	port->tty->low_latency = low_latency;

 	port_number = port->number - port->serial->minor;
 	switch (port_number) {

--


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/