Re: [PATCH 2/2] make work have a static address in do_boot_cpu()

From: Ingo Molnar
Date: Fri Feb 22 2008 - 04:47:25 EST



* Glauber Costa <glommer@xxxxxxxxx> wrote:

> > Looks way overkill. Doesn't something like:

> > > struct create_idle create_idle = {
> > > - .work = __WORK_INITIALIZER(create_idle.work, do_fork_idle),
> > > .cpu = cpu,
> > > .done = COMPLETION_INITIALIZER_ONSTACK(create_idle.done),
> > > };
> > > + INIT_WORK(&create_idle.work, do_fork_idle);
> >
> > work?
>
> Indeed.
>
> I missed the static lock_class_key definition inside INIT_WORK macro.
> It does the job neatly.

could you resend the updated patch?

Ingo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/