Re: [PATCH] xen: Implement getgeo for Xen virtual block device.

[Junio C Hamano]

Jeremy Fitzhardinge <jeremy@xxxxxxxx> writes:

> Putting the From: in the Signed-off-by block is a result of two thoughts:
>
>   1. putting it at the top makes the most sense from an email
>      perspective, but it often seem to get lost by various
>      patch-posting programs if it gets tangled in the Subject/summary
>      part of the patch.  The result is that it needs to float in an odd
>      way:
>
>          Subject: wooble the foo
>
>          From: Foo Woobler <foo@xxxxxxxxxx>
>
>          Wooble foos in the appropriate manner.
>
>          Signed-off-by: Foo Woobler <foo@xxxxxxxxxx>
>          Cc: Bar Mangler <bar@xxxxxxxxxx>
>
>   2. There's already a block of email addresses which describe how
>      people relate to this patch,...

In addition to "From: ", you can place "Subject: " and "Date: "
at the beginning to make sure Linus or whoever applies patches
would not get the authorship information from the e-mail itself
you send (this is especially true when you are forwarding
somebody else's patch).

Mnemonic is that the equivalents to E-mail headers go at the
top.  You will never have Signed-off-by:, Tested-by:, nor
Acked-by: in your e-mail headers.  They go at the bottom.

	This is just a toolsmith speaking, I am not in any way
	trying to set a policy for this list.

I do not know where that Cc: near S-o-b: comes from, though.  It
is not accepted at the top as there is no place for such an
information in commits.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/