Re: [PATCH] Allow populate_rootfs() to be called early

From: Ãric Piel
Date: Thu Feb 21 2008 - 16:27:48 EST


21/02/08 20:04, Christoph Hellwig wrote/a Ãcrit:
> On Thu, Feb 21, 2008 at 08:02:36PM +0100, Eric Piel wrote:
>> It's been a week and no one has screamed, so I guess the idea looks fine
>> to everyone :-)
>>
>> Here is a boot tested patch for integration. In addition to the previous
>> version, it removes also rootfs_initcall(), and uses fs_initcall_sync().
>> There should be absolutely no difference in behaviour as there was no
>> user of fs_initcall_sync() in the kernel.
>>
>> I'm not sure what should be the best tree to go through. Maybe the ACPI
>> tree, as all this is needed for CONFIG_ACPI_CUSTOM_DSDT_INITRD...
>
> Actually I've just got a report today where we get an uninitialized
> spinlock due to this in -mm. It's probably possible to work around it,
> though.
What do you mean by "due to this"? Due to userspace helper being called
too early? Then this patch should fix the bug.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/