Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constantin boot code

[H. Peter Anvin]

Cyrill Gorcunov wrote:
> [H. Peter Anvin - Thu, Feb 21, 2008 at 11:52:56AM -0800]
> > Cyrill Gorcunov wrote:
> > > This patch replaces 4096 numeric constant with PAGE_SIZE macro.
> > > Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
> > > ---
> > > Text segments of old and new files *are* the same so
> > > it wouldn't break current kernel.
> > NAK.
> >
> > This is NOT PAGE_SIZE (even though the two values are coincidentally the 
> > same, for historical reasons.)
> >
> > 	-hpa
>
> hmm, why the comment on boot_param structure definition calls
> it "zeropage"? Anyway really thanks for review and catched this.

Historical reasons... it used to be a "magic page" -- that's long since 
gone.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/