Re: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div()

From: Andreas Schwab
Date: Thu Feb 21 2008 - 11:39:15 EST


David Howells <dhowells@xxxxxxxxxx> writes:

> if (time_offset < 0) {
> - temp64 = -temp64;
> - do_div(temp64, mtemp);
> + utemp64 = -temp64;
> + do_div(utemp64, mtemp);
> freq_adj -= temp64;

do_div previously modified temp64 by side effect, now it no longer does
that.

> } else {
> - do_div(temp64, mtemp);
> + utemp64 = temp64;
> + do_div(utemp64, mtemp);
> freq_adj += temp64;

Same.

Andreas.

--
Andreas Schwab, SuSE Labs, schwab@xxxxxxx
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/