Re: [PATCH] Document huge memory/cache overhead of memory controllerin Kconfig

From: Balbir Singh
Date: Thu Feb 21 2008 - 09:57:19 EST


KOSAKI Motohiro wrote:
> Hi
>
>> > >> For ordinary desktop people, memory controller is what developers
>> > >> know as MMU or sometimes even some other mysterious piece of silicon
>> > >> inside the heavy box.
>> > >
>> > >Actually I'd guess 'memory controller' == 'DRAM controller' == part of
>> > >northbridge that talks to DRAM.
>> >
>> > Yeah that must have been it when Windows says it found a new controller
>> > after changing the mainboard underneath.
>>
>> Just for fun... this option really has to be renamed:
>
> I think one reason of many people easy confusion is caused by bad menu
> hierarchy.
> I popose mem-cgroup move to child of cgroup and resource counter
> (= obey denend on).
>
> if you don't mind, please try to following patch.
> may be, looks good than before.
>

Sure makes sense

> ---
> init/Kconfig | 52 ++++++++++++++++++++++++++--------------------------
> 1 file changed, 26 insertions(+), 26 deletions(-)
>
> Index: b/init/Kconfig
> ===================================================================
> --- a/init/Kconfig 2008-02-17 16:44:46.000000000 +0900
> +++ b/init/Kconfig 2008-02-21 23:33:51.000000000 +0900
> @@ -311,6 +311,32 @@ config CPUSETS
>
> Say N if unsure.
>
> +config PROC_PID_CPUSET
> + bool "Include legacy /proc/<pid>/cpuset file"
> + depends on CPUSETS
> + default y
> +
> +config CGROUP_CPUACCT
> + bool "Simple CPU accounting cgroup subsystem"
> + depends on CGROUPS
> + help
> + Provides a simple Resource Controller for monitoring the
> + total CPU consumed by the tasks in a cgroup
> +
> +config RESOURCE_COUNTERS
> + bool "Resource counters"
> + help
> + This option enables controller independent resource accounting
> + infrastructure that works with cgroups
> + depends on CGROUPS
> +
> +config CGROUP_MEM_CONT
> + bool "Memory controller for cgroups"
> + depends on CGROUPS && RESOURCE_COUNTERS
> + help
> + Provides a memory controller that manages both page cache and
> + RSS memory.
> +

We have some more changes planned for the text and renames planned, including
calling the component as a memory resource controller. The menu changes make
sense, so feel free to push them

Acked-by: Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx>

> config GROUP_SCHED
> bool "Group CPU scheduler"
> default y
> @@ -352,20 +378,6 @@ config CGROUP_SCHED
>
> endchoice
>
> -config CGROUP_CPUACCT
> - bool "Simple CPU accounting cgroup subsystem"
> - depends on CGROUPS
> - help
> - Provides a simple Resource Controller for monitoring the
> - total CPU consumed by the tasks in a cgroup
> -
> -config RESOURCE_COUNTERS
> - bool "Resource counters"
> - help
> - This option enables controller independent resource accounting
> - infrastructure that works with cgroups
> - depends on CGROUPS
> -
> config SYSFS_DEPRECATED
> bool "Create deprecated sysfs files"
> depends on SYSFS
> @@ -387,18 +399,6 @@ config SYSFS_DEPRECATED
> If you are using a distro that was released in 2006 or later,
> it should be safe to say N here.
>
> -config CGROUP_MEM_CONT
> - bool "Memory controller for cgroups"
> - depends on CGROUPS && RESOURCE_COUNTERS
> - help
> - Provides a memory controller that manages both page cache and
> - RSS memory.
> -
> -config PROC_PID_CPUSET
> - bool "Include legacy /proc/<pid>/cpuset file"
> - depends on CPUSETS
> - default y
> -
> config RELAY
> bool "Kernel->user space relay support (formerly relayfs)"
> help


--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/