Re: [PATCH] X86: remove WARN_ON if MTRRs are all blank

[Joerg Roedel]

On Thu, Feb 21, 2008 at 02:03:32PM +0100, Ingo Molnar wrote:
> 
> * Joerg Roedel <joerg.roedel@xxxxxxx> wrote:
> 
> > > >  	if (!highest_pfn) {
> > > >  		printk(KERN_WARNING "WARNING: strange, CPU MTRRs all blank?\n");
> > > > -		WARN_ON(1);
> > > >  		return 0;
> > > >  	}
> > > 
> > > instead of obscuring a possibly useful warning, please instead 
> > > detect that it's a KVM guest and skip both the warning and the 
> > > backtrace in that case.
> > 
> > How usefull is the backtrace in that place? I agree that the printk 
> > warning may be usefull, but I don't see why the backtrace from the 
> > WARN_ON is necessary.
> 
> it allows us to collect such things on kerneloops.org for example.

Makes sense. I will send an updated patch.

Joerg

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/