Re: [PATCH] viocons: BKL locking

From: Stephen Rothwell
Date: Thu Feb 21 2008 - 06:10:52 EST


Hi Alan,

On Thu, 21 Feb 2008 10:50:56 +0000 Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, 21 Feb 2008 14:58:29 +1100
> Paul Mackerras <paulus@xxxxxxxxx> wrote:
>
> > Alan Cox writes:
> >
> > > For some weird reason I can't ascertain (translation "I think its
> > > broken") the viocons driver calls directly into the n_tty ldisc code even
> > > if another ldisc is in use. It'll probably break if you do that but I'm
> > > just fixing the locking and adding a comment that its horked.
> >
> > Looks to me like it (viotty_ioctl) should return -ENOIOCTLCMD instead
> > of calling n_tty_ioctl -- do you agree?
>
> I think that is probably what is intended. That would then bounce back
> throuh the tty layer to the right places.

The other thing to note is that viocons is deprecated (we wrote another
backend to hvc as an alternative console for legacy iSeries) and will
hopefully be removed sometime soon so don't spend any time on it.

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature