Re: tsc breaks atkbd suspend

From: Thomas Gleixner
Date: Wed Feb 20 2008 - 01:52:36 EST


On Tue, 19 Feb 2008, Len Brown wrote:

> On Tuesday 19 February 2008 11:51, Thomas Gleixner wrote:
> > On Tue, 19 Feb 2008, Ingo Molnar wrote:
> > > * Pavel Machek <pavel@xxxxxx> wrote:
> > >
> > > > TSC is used even on machines when CONFIG_X86_TSC is not set (X86_TSC
> > > > means _require_ TSC), but it is not properly disabled when it is
> > > > unusable, because acpi code understood the config switch as "may use
> > > > TSC".
> > > >
> > > > This actually fixes suspend problems on my x60.
> > >
> > > ah! This makes tons of sense. I've applied your patch
>
> please do not.

It's not in the -mm branch.

> > > - but i guess it should go via the ACPI tree.
>
> yes.
>
> > Right. The breakage was introduced there when IA64 switched to
> > GENERIC_TIME and the X86_TSC dependency was added.
>
> so do we need a patch for 2.6.23.stable and 2.6.24.stable?

Yes.

Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/