Re: [PATCH] do_signal_stop: use signal_group_exit()

From: Eric W. Biederman
Date: Tue Feb 19 2008 - 21:40:21 EST


Oleg Nesterov <oleg@xxxxxxxxxx> writes:

>
>>From 2.6.25-rc2-mm1.bz2 patch:
>>
>> - .ioctl = tty_ioctl,
>> + .unlocked_ioctl = tty_ioctl,
>
> and this is why this didn't happen before, I guess.

Right. Does anyone know what kind of audit was made of the tty code
to ensure everything would be fine?

It it was pretty thorough and it was just this little corner case
it makes sense to get the struct tty locking for pids correct.

Otherwise since the tty layer is historically not especially good
with it's locking. We should just revert the change above, and save
attacking this until someone has time to do a thorough review.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/