Re: arch/x86/kernel/acpi/sleep_32.c not compiled ?

From: Pavel Machek
Date: Tue Feb 19 2008 - 18:44:39 EST


On Wed 2008-02-20 00:41:46, Rafael J. Wysocki wrote:
> On Tuesday, 19 of February 2008, Pavel Machek wrote:
> > On Tue 2008-02-19 22:02:52, Rafael J. Wysocki wrote:
> > > On Tuesday, 19 of February 2008, Thomas Petazzoni wrote:
> > > > Hi,
> > >
> > > Hi,
> > >
> > > > Maybe I'm missing something completely obvious, but I don't see where
> > > > the arch/x86/kernel/acpi/sleep_32.c file gets compiled. The Makefile in
> > > > that directory compiles sleep.o, but doesn't compile sleep_$(BITS).o:
> > > >
> > > > obj-$(CONFIG_ACPI) += boot.o
> > > > obj-$(CONFIG_ACPI_SLEEP) += sleep.o wakeup_$(BITS).o
> > > >
> > > > ifneq ($(CONFIG_ACPI_PROCESSOR),)
> > > > obj-y += cstate.o processor.o
> > > > endif
> > >
> > > No, the file is not build now.
> > >
> > > Pavel, is this file really necessary?
> >
> > sleep_32.c is obsolete. It tried to do s2ram whitelist in kernel, with
> > just one entry ;-). Remove it. If Mirek Spousta (probably last
> > remaining owner of whitelisted toshiba, he got it from me ;-)
> > complains, I'll give him better machine or something.
>
> Well, then perhaps we also should remove the S1 quirk for the same box from
> drivers/acpi/sleep/main.c ?

Yes we probably can do that.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/