Re: [patch 07/13] Initialize per cpu lowcores on cpu hotplug.

From: Bastian Blank
Date: Tue Feb 19 2008 - 10:14:17 EST


On Tue, Feb 19, 2008 at 03:40:54PM +0100, Martin Schwidefsky wrote:
> + /*
> + * Only need to copy the first 512 bytes from address 0. But since
> + * the compiler emits a warning if src == NULL for memcpy use copy_page
> + * instead. Copies more than needed but this code is not performance
> + * critical.
> + */
> + copy_page(lowcore, &S390_lowcore);

Boah, workaround alert. Why do you not fix the compiler?

Bastian

--
We fight only when there is no other choice. We prefer the ways of
peaceful contact.
-- Kirk, "Spectre of the Gun", stardate 4385.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/