Re: [PATCH 4/5] x86_64: check msr to get mmconfig for amd family10h opteron v3

From: Ingo Molnar
Date: Tue Feb 19 2008 - 05:14:18 EST



* Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:

> > Index: linux-2.6/arch/x86/pci/mmconfig-shared.c
> > ===================================================================
> > --- linux-2.6.orig/arch/x86/pci/mmconfig-shared.c
> > +++ linux-2.6/arch/x86/pci/mmconfig-shared.c
>
> Ingo/Thomas,
>
> It seems you missed this one in the 5.
>
> this one should be safe. it only reads msr.

we picked up all of your patches - have you checked the x86.git#testing
branch, or only the x86.git#mm branch? We started x86.git#testing
recently, it includes more bleeding-edge stuff and wider, cross-tree
features as well.

> Andi had concern with other one that was touching msr. I will keep
> that one in my local tree.

We've got that one queued up in x86.git#testing as well. Someone on lkml
having concerns is not a basis to not deal with a patch. What matters
is: are those concerns well-founded? If you do not agree with the
concerns then just indicate it to us when re-submitting but do not drop
patches. Your patches have a good track record so please do not let
yourself get scared away from contributing. Please do not keep patches
in your local tree, we'd like Linux to work fine out of box, on as broad
range of hardware as possible.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/