Re: [2.6 patch] fs/drop_caches.c: make 2 functions static

From: Neil Brown
Date: Mon Feb 18 2008 - 16:45:21 EST


On Monday February 18, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> On Sun, 17 Feb 2008 10:17:46 +0200 Adrian Bunk <bunk@xxxxxxxxxx> wrote:
>
> > This patch makes the following needlessly global functions static:
> > - drop_pagecache()
> > - drop_slab()
> >
> > Signed-off-by: Adrian Bunk <bunk@xxxxxxxxxx>
..
>
> This was originally done because Neil said that he planned to use these in
> nfsd. I guess that didn't happen, and an additional patch would be needed
> here anyway to do the module exports. So.... zap.

Did I? I wonder why. Neither my memory or my mail archive gives me
any hints, so I suspect it must have just been a passing fancy that
resolved into a really dumb idea (as so many passing fancies do).

Zap-supported-by: NeilBrown <neilb@xxxxxxx>

Hmmm... I guess that should really be

Acked-By: NeilBrown <neilb@xxxxxxx>
;-)

NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/