Re: [PATCH] mm: setup_usemap() must be __meminit

[Sam Ravnborg]

On Sun, Feb 17, 2008 at 09:38:55PM +0100, Geert Uytterhoeven wrote:
> On Sun, 17 Feb 2008, Sam Ravnborg wrote:
> > On Sun, Feb 17, 2008 at 01:31:14PM +0100, Geert Uytterhoeven wrote:
> > > On Sun, 17 Feb 2008, Geert Uytterhoeven wrote:
> > > > On m68k (CONFIG_SPARSEMEM is not set), I get:
> > > > 
> > > >     WARNING: vmlinux.o(.meminit.text+0x36c): Section mismatch in reference from the function free_area_init_core() to the function .init.text:setup_usemap()
> > > >     The function __meminit free_area_init_core() references
> > > >     a function __init setup_usemap().
> > > >     If free_area_init_core is only used by setup_usemap then
> > > >     annotate free_area_init_core with a matching annotation.
> > > > 
> > > > If CONFIG_SPARSEMEM is set, the problem is  not noticed because setup_usemap()
> > > > is always inlined.
> > > > 
> > > > Properly annotating setup_usemap() and usemap_size() fixes it.
> > > 
> > > Woops, hit the send button too soon.
> > > 
> > > setup_usemap() calls alloc_bootmem_node(), causing a whole new
> > > avalanche of warnings to be fixed up :-(
> > 
> > Something you like me to help with?
> 
> Yes, that would be nice.

I tried the patch posted by Alexander previously.
After reviewing it for some time I convinced myself the
patch is correct (has stayed in my to-be-looked-at queue for a while).

See:
http://lkml.org/lkml/2008/2/3/129

I will ask Andrew to take it.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/