Re: [PATCH 1/5] signal(x86_32): Improve the signal stack overflow check

From: Valdis . Kletnieks
Date: Mon Feb 18 2008 - 13:06:07 EST


On Mon, 18 Feb 2008 18:22:05 +0800, Shi Weihua said:

> - /*
> - * If we are on the alternate signal stack and would overflow it, don't.
notice this ^
> - * Return an always-bogus address instead so we will die with SIGSEGV.

> + * If we are on the alternate signal stack and would
> + * overflow it, don't return an always-bogus address
missing here ^
> + * instead so we will die with SIGSEGV.

"don't. Return" is a vastly different semantic than "don't return".

I think the same comment error was cut-n-pasted into all 5 patches...

Attachment: pgp00000.pgp
Description: PGP signature