Re: Problem with /proc/sys/vm/lowmem_reserve_ratio ???

[Rik van Riel]

On Mon, 18 Feb 2008 09:33:05 -0500
Jeff Moyer <jmoyer@xxxxxxxxxx> wrote:

> Larry Woodman <lwoodman@xxxxxxxxxx> writes:
> 
> > balance_pgdat() calls zone_watermark_ok() three times, the first call
> > passes a zero(0) in as the 4th argument.  This 4th argument is the
> > classzone_idx which is used as the index into the
> > zone->lowmem_reserve[] array.  Since setup_per_zone_lowmem_reserve()
> > always sets the zone->lowmem_reserve[0] = 0(because there is nothing
> > below the DMA zone), zone_watermark_ok() will not consider the
> > lowmem_reserve pages when zero is passed as the 4th arg.  Shouldnt this
> > 4th argument be either "i" or "nr_zones - 1" ???
> 
> That certainly looks like the intent of this code.  I'd say patch 1,
> passing i in as the 4th arg.  Rik, what do you think?

Yes, that is probably the best option.

-- 
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/