Re: [PATCH] Fix left over EFI cache mapping problems

From: Ingo Molnar
Date: Mon Feb 18 2008 - 09:06:22 EST



* Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> > UEFI specification 2.1 (section 6.2, page 124) that the
> > NumberOfPages (num_pages) of EFI_MEMORY_DESCRIPTOR
> > (efi_memory_desc_t) must be "Number of 4KB pages in the memory
> > region". So we need not worry about potential EFI_PAGE_SHIFT
> > changes.
>
> Then it would be cleaner to just use PAGE_SIZE in the x86 specific EFI
> code imho.

(as i suggested in the mail Ying replied to.)

But ... as long as ia64 uses EFI too i dont mind if it's using
EFI_PAGE_SHIFT consistently, even in the arch/x86-only files.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/