Re: [patch] suspend/resume self-test

From: Rafael J. Wysocki
Date: Mon Feb 18 2008 - 06:06:26 EST


On Monday, 18 of February 2008, David Brownell wrote:
> > >   - Includes a command line parameter, which needs work yet ... it
> > >     currently turns this test off, but it should also let the target
> > >     state be specified (and maybe even default to "no test").
>
> I think "no test" should be the default;

Agreed.

> STR working sanely on x86 is unfortunately too much a surprise.

Well, out of 4 boxes I have, one doesn't resume from suspend, but this is the
one that's terminally broken otherwise. :-)

> Someone more active in PM testing should update that.
>
>
> > > Also includes some Kconfig tweaks to help reduce configuration bugs on
> > > x86, by avoiding the legacy RTC driver when the generic RTC framework
> > > is enabled ... those should become a separate patch.
>
> That's already been split out in a separate patch, now in MM.
> Though it may deserve another tweak, forcing off *all* legacy
> RTC drivers if the new framework is enabled.

Yes, the legacy drivers shoule depend on !(new framework).

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/